Skip to content

refactor: update blas/ext/base/ssum to follow current project convent… #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 20, 2024

Conversation

raunak-dev-edu
Copy link
Contributor

Resolves #1540.

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/ssum to follow current project conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@raunak-dev-edu raunak-dev-edu changed the title refactor: update blas/ext/base/ssum to follow current project convent… refactor: update blas/ext/base/ssum to follow current project convent… Mar 9, 2024
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading good, requested changes. Once done this PR will be ready to merge.

@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Changes Pull request which needs changes before being merged. labels Mar 10, 2024
raunak-dev-edu and others added 14 commits March 10, 2024 19:17
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
Signed-off-by: Raunak Kumar Gupta <95216822+raunak-dev-edu@users.noreply.github.com>
@raunak-dev-edu
Copy link
Contributor Author

@Pranavchiku I have applied the chnges as per requested. Please re-review it.

@kgryte
Copy link
Member

kgryte commented Mar 20, 2024

@raunak-dev-edu Looks like we're getting lint failures on this PR. Those should be addressed before we review.

@Planeshifter Planeshifter self-requested a review April 20, 2024 17:11
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @raunak-dev-edu!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 20, 2024
@Planeshifter Planeshifter merged commit 8d66a07 into stdlib-js:develop Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssum to follow current project conventions
4 participants